dev #5
Loading…
Reference in a new issue
No description provided.
Delete branch "dev"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Root cause of the 'Stop button cancels mid-loop' CI flake: success-path tests left a live 1.2s setTimeout(onClose) that survived RTL cleanup(); under CI load it fired inside a later test's locate-Stop->click gap, unmounting the dialog mid-test so the click hit a detached node and cancelRef never flipped — the loop ran to the 3rd key ('called 2 times, but got 3'). Fix at the component seam: a file-local useAutoClose hook (ref-held timer id, cleared before rescheduling + on unmount) replaces all seven bare timeout sites. No production behavior change (close() is idempotent; delay and close semantics identical while mounted). Regression test ('unmount cancels the pending success auto-close', real timers) fails against the pre-fix component and passes with it. Gate: 2177 unit tests, typecheck, lint, build, all check:* green; 10x file runs + 3x web suite + 2-CPU concurrent stress all clean. Plans updated (item 3, Principal-directed scope amendment 2026-08-15; reviewer's two doc corrections applied); revokeObjectURL 0-ms defers recorded in backlog. Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>