v2.1 #8
Loading…
Reference in a new issue
No description provided.
Delete branch "dev"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
03efa96), T1 in-progress (wave 1)932b204) + T2 done (213684a) — wave-1 alias scheme green at unit level; T3 E2E in flightv2.1 T4 — the version's centerpiece: the source set can grow without leaving the workbench (leaving would rewrite the default query and re-fetch all sources on return). - SourcePicker modal (DownloadDialog pattern: overlay + scrim + role=dialog + useDialogFocus trap/Escape/restore), hosted from the SourceChips row via a '+ Add files' trigger shown whenever the panel holds an origin bucket; SourceChips' MVP no-picker gate docblock rewritten to the open state. - Browsing reuses the list-view data layer wholesale: local prefix + loadedPages state against the FIXED origin bucket (usePaginatedList mounting the useS3List ladder), client-side isQueryableExt filter, prefix rows navigate (visually distinct, NOT selectable — the selectable-folders backlog stays unprecluded), Load-more per the list-view semantics, in-dialog breadcrumbs, virtualized rows. - Staging is picker-LOCAL (Map<key,{key,size}>), accumulates across prefixes, dies with the dialog — never the shared selection store. - Held rows (same bucket+key as a held source) render indicated ('already added') and cannot be staged. - Running combined-size indicator (held + pending, declared LIST sizes) with ok/warn/over tiers against SQL_QUERY_WARN_SIZE / SQL_QUERY_LIMIT_SIZE — shape-coded (no-glyph/⚠/✕), informational only, enforcement stays at load; no pre-flight gate. - Commit = setSources([...held, ...picked]) (no origin argument) PLUS a direct loadSources(getCredentials()) from the commit handler — closes the post-L2-cancel gap (ADR #50 §5); picker never calls setSqlText; close-on-commit. Every close path funnels through the single closePicker(reason) seam (T7 slots its confirm-on-dirty-close guard there; T4 closes silently per the spec baseline). - i18n (ADR #41): 24 sql.picker.* descriptors in sql/messages.ts, en-US extract + fr-FR translation in the same change; the catalog size tripwire (494→518) and the i7 placeholder allowlist (bucket/ location/name/warn — trusted UI state) updated alongside. Visual loop (compose.e2e stack + on-prem vision review, light+dark, 1440x900/780x493/375x667): verified browse/stage-across-prefixes/ held/load-more/empty/warn/over/commit/discard/editor-untouched, fixed a short-viewport footer clip (list region now yields to a min-height floor) and strengthened the warn/over banner tints (10%→20%). Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>a2c7587, review-approved (should-fix carried to T7)v2.1 T7 — the SourcePicker close seam now guards dirty closes: a discard-intent close with a non-empty staged batch arms an in-footer role=alertdialog discard/stay confirmation (SqlToolbar warn-gate idiom) instead of closing; confirm discards AND closes, Stay (or any repeated close intent while armed — second-Escape-cancels) returns to the picker with staging intact. Clean batch and post-commit closes stay silent (sql-query.md §"The source picker"). The breadcrumb row becomes a nav landmark (aria-label exposed; Breadcrumbs.tsx idiom), and fr-FR stageAria verb becomes "Préparer {name}" to stop colliding with the commit button "Ajouter" for FR screen-reader users. Catalogs: +3 sql.picker.confirm* keys, en-US extract + fr-FR in the same change; tripwire pin 518 → 521. Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>aa7ade3, must-fix763c618, review-approvedf455228, must-fixf5182d9, review-approved; backlog: pagination error-retry gap4a6f635+9f3608e, review-approved8e1aa27, battery 8/8 green (2823 tests, independent e2e 19/19); execution complete, ship-ready