Principal-directed promotion of the two session-restore backlog items
(ephemeral reload + hard-reload/deep-link bounce) into a single-purpose
maintenance version; same root cause (module-scope router creation races
async boot/restore), one fix. Fix shapes (router-after-boot vs guard-gated
boot), comment truth-up, and the regression-E2E coverage are recorded as
promotion commitments; the Plan layer awaits the Principal's greenlight.

Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>

docs(architecture): ADR #51 — router exists only after boot (v2.1.1 boot-order race) b911761d23

Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>

docs(plans): v2.1.1 plan layer — greenlight recorded, single wave T1-T3 per ADR #51 4246c63571

Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>

fix(web): build router after boot; pre-boot loader throws invariant (ADR #51 ) 693613097c

The browser router was created at module scope; react-router's
constructor runs the initial navigation immediately, so requireSession
saw status 'uninitialized' and bounced valid restorable sessions to
/login before main.tsx's boot() reached restoreOnLoad(). Per ADR #51
shape (a): buildRouter() factory called in the boot-then-render seam;
App receives the router as a prop; the guard's 'uninitialized' branch
becomes a loud invariant Error (never a redirect). Comment truth-up
sweep: session-guard.ts header, main.tsx docblock, App.tsx docblock.

Blast-radius correction vs ADR #51 §4: app-locale.test.tsx (not just
session-guard.test.ts) needed adapting — it vi.mocks the router module
and renders the production <App />, which now requires the router
prop. The mock exposes the same buildRouter() factory over its shared
singleton memory router; suite design unchanged. cross-tab-component
and error-pages byte-untouched.

Verification: pnpm -r build, pnpm -r test (2907 passing), typecheck,
lint — all green.

Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>

test(e2e): session-restore regression matrix; i18n live-switch truth-up 148591a362

Commitment 3 of the v2.1.1 plan: tests/e2e/session-restore.spec.ts
pins the reload/deep-link matrix — post-login reload x {remember ON,
remember OFF}, deep link with a valid restorable session, and the
negatives (absent session and expired session bounce to /login, with
the expired blob erased per auth-session.md). Expiry simulated by
backdating lastActivity past the live /config sessionTimeoutSeconds
(no forked short-timeout stack); testing note added to auth-session.md
(mechanics only, the plan's one permitted spec edit).

Second blast-radius correction: i18n-live-switch.spec.ts test 1 had
pinned the pre-fix boot-order race itself — asserting the French LOGIN
FORM after reload via a documented workaround. Post-fix it asserts the
protected surface re-renders authenticated in French (strictly
stronger; i18n contract unchanged).

5/5 new tests green (run twice), minio-happy-path smoke 13/13,
pnpm -r test 2907/2907.

Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>

docs(plans): v2.1.1 T3 review clean — rulings recorded, close-out next 2f892a0e34

Reviewer verdict CLEAN over 4246c63..148591a with no change requests:
loud invariant throw kept (ruling 1), both blast-radius adaptations
accepted (rulings 2-3), V7-era sketch comments left as-is (ruling 4).

Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>

docs(plans): v2.1.1 close-out battery green — ship-ready declared 298f522751

Full battery against 2f892a0 (clean tree): build, unit 2907/2907,
integration 7/7, E2E 66 passed / 0 failed / 5 AWS-gated skips with
0 retries, typecheck, lint, duckdb-pin + locale-catalog gates (both
no-ops as expected). All stacks torn down; tree clean. v2.1.1 awaits
the Principal's tag; post-tag file deletion per convention.

Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>

docs(architecture): ADR #51 §4 amended — post-implementation blast-radius corrections (app-locale module mock, i18n-live-switch bug pin)

CI / pnpm gate (typecheck, lint, build, test) (push) Successful in 2m7s

Details

CI / pnpm gate (typecheck, lint, build, test) (pull_request) Successful in 1m46s

Details

release / build + scan + publish (push) Successful in 44s

Details

641910070d

Co-Authored-By: Xavier's assistant <assistant@gijoe88.com>

xavier merged commit 641910070d into main

2026-08-27 23:10:36 +02:00

assistant referenced this pull request from a commit

2026-08-29 22:36:18 +02:00

feat(web): migrate login + SQL-export emitters to notification surface; query-error x (v2.2 wave 2)

No reviewers

No labels

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

xavier/s3-vedrfolnir!9

No description provided.

Rows
Columns